Sync latest commits from upstream #9

Merged

Mssol94 merged 6 commits from ci-upstream-sync into master 2026-10-11 01:42:11 +02:00

Conversation 0 Commits 6 Files changed 2 +23 -2

forgejo-actions commented 2026-10-02 02:01:05 +02:00

Copy link

This PR syncs the latest commits from the upstream repository.

This PR syncs the latest commits from the upstream repository.

forgejo-actions added the

Upstream

label 2026-10-02 02:01:05 +02:00

forgejo-actions added 5 commits 2026-10-08 02:01:23 +02:00

[#402] Add crates.io package metadata ... 63996c7437

Problem: Cargo.toml has none of the fields crates.io displays:
description, license, repository, readme, keywords and categories.
It also does not say which Rust version it needs, so an older
compiler fails with a confusing error deep in a dependency.

Solution: fill in these fields. The description is the GitHub
repository description, and the license is MPL-2.0, as in the REUSE
headers. rust-version is 1.85. It is the oldest release that builds
the crate when dependencies are resolved fresh, as `cargo install`
does. On 1.84, the latest clap and hashbrown fail to build.

[#402] Use the MSRV-aware dependency resolver ... 7075d65334

Problem: `rust-version` is 1.85, but with edition 2018 Cargo uses
resolver v1, which ignores `rust-version` when picking dependency
versions. Once a dependency releases a version that needs a newer
compiler, a plain `cargo install deploy-rs` on 1.85 picks it and fails
to build.

Solution: set `resolver = "3"`. It prefers dependency versions whose
`rust-version` fits ours, and it needs Cargo 1.84, which is below our
MSRV. It also brings resolver v2's feature unification rules. The
build and tests pass, and Cargo.lock does not change.

This changes what "measuring the MSRV" means. Under v1, the previous
commit's 1.85 was the true minimum for the latest dependency
versions. Under v3, `rust-version` also steers which versions get
picked, so lowering it would make the resolver pick older
dependencies to match, and "the oldest version that builds" is no
longer a fixed target to bisect toward. 1.85 is kept as a floor we
maintain rather than a value to keep re-deriving: it is also the
exact rustc version (1.85.0) that this repository's own flake pins
today, via nixpkgs bd3bac8bfb (2025-03-26), so it cannot be lowered
without also losing margin in this project's own Nix CI.

[#402] Exclude Nix-only files from the published package ... c142ae9073

Problem: cargo package includes every file tracked by git, which
pulls in 39 files that have nothing to do with building the Rust
crate: flake.nix, flake.lock, the Nix example flakes under examples/,
the e2e tests under nix/tests/, the CI workflow, and .gitignore.

Solution: exclude them with the `exclude` field. `nix/
transform-deploy.nix` stays in, since src/cli.rs embeds it with
`include_str!` and needs it present when building from the published
tarball. `cargo package` now includes 17 files instead of 39.

[Chore] Fix infinite recursion in the simple example's checks output ... e0c698ef95

Problem: checks was nested inside deploy.nodes.example instead of
being a sibling of deploy. Evaluating it forces self.deploy, which
contains the node, which contains checks again: infinite recursion.
nix flake check never caught this, since it only looks for checks at
the top level, not buried inside a deploy.nodes.* entry, so it never
evaluated the attribute at all.

Solution: move checks out to be a top-level output, alongside deploy.

Merge pull request #403 from serokell/heitor-lassarote/#402-crates-io-metadata ... 45ba3f8c5c

[#402] Add crates.io package metadata

Mssol94 added 1 commit 2026-10-08 16:32:29 +02:00

Merge branch 'master' into ci-upstream-sync 1bbf426993

forgejo-actions force-pushed ci-upstream-sync from 1bbf426993 to 45ba3f8c5c 2026-10-09 02:01:13 +02:00 Compare

Mssol94 added 1 commit 2026-10-09 03:24:37 +02:00

Merge branch 'master' into ci-upstream-sync c47a5f1f93

forgejo-actions force-pushed ci-upstream-sync from c47a5f1f93 to 45ba3f8c5c 2026-10-10 02:01:27 +02:00 Compare

Mssol94 added 1 commit 2026-10-11 00:44:55 +02:00

Merge branch 'master' into ci-upstream-sync ff54e2b3e2

Mssol94 merged commit b30e84113e into master 2026-10-11 01:42:11 +02:00

Mssol94 referenced this pull request from a commit 2026-10-11 01:42:11 +02:00

Merge pull request 'Sync latest commits from upstream' (#9) from ci-upstream-sync into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Upstream

Pull latest commits from upstream

No labels

Upstream

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mssol94/deploy-rs!9

No description provided.